-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
Fixed Instagram false negative #2624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Automatic validation of changes
Failures were detected on at least one updated target. Commits containing accuracy failures will often not be merged (unless a rationale is provided, such as false negatives due to regional differences). |
|
This pull request is as part of efforts in the Hacktoberfest program. Also, the checks may be wrong as it is using the wrong data.json? Or maybe it's because this change cannot detect private accounts. My proposed solution would be to implement an Instagram (public) and an Instragram (private) through imginn.com. This way, users can know if the Instagram account is public, or is private and whether they should use Instagram or Imginn to view the target's profile page. |
The tests are done on modified data.json itself. Also, when i try to implement your changes locally, I seem to not get any output and all upon checking for a username on Instagram. Is it region specific too? |
|
Yeah, I think Instagram is region-specific. I think that's causing the problems |
|
I think a solution would be to use Error messages instead of status codes. That way, it can detect both public and private accounts in all regions |
Instagram currently uses layered WAF and checking whether a username is valid requires Instagram Graph API, which is a pain in itself. Adding Instagram I feel won't be straight forward. However, if you are interested in it. Do go through this article. There seems to be a workaround to directly query Instagram Public profiles. |
|
Hi, should I do any updates on this, or close this PR? |
By removing the use of imginn.com, this pull request successfully removes the false negative of Instagram.
What I changed
Instead of using imginn.com as the probing URL for Instagram, i removed it so Sherlock should scan the instagram.com. Note that I ran this without an Instagram account, showing that most, if not all profiles are visible without the use of imginn.com. This is a fix to the false negative.
Proof it works.
This is the result before the change. I've cut it down to only show the section missing Instagram.
This is the result after the change
As you can see, the change has successfully allowed the detection of NASA's instagram account.